Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Space Ruin: Drakehound Skiff Wreck #27056

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

PollardTheDragon
Copy link
Contributor

@PollardTheDragon PollardTheDragon commented Oct 11, 2024

What Does This PR Do

Adds the Drakehound Skiff Wreck space ruin, alongside a Drakehound Breacher unathi simplemob. The ruin contains 6 drakehound breachers, who drop pirate loot on death. Notable loot within the ruin is in the central room, which has a unathi breacher spacesuit box, a ceremonial claymore, and some gold in both refined and unrefined forms.

Why It's Good For The Game

More diversity of space ruins is good. Having more things for explorers to explore that don't contain syndicate or otherwise gamebreaking loot is a plus.

Images of changes

image

Testing

Loaded game, space ruin spawned in. Killed drakehounds. Looted joint. Left.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image

Changelog

🆑
add: Drakehound skiff space ruin and accompanying simple mob
/:cl:

Copy link
Contributor

@1080pCat 1080pCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding some /landmark/damageturf to some areas, given that the ship is very clearly damage, but the floor tiles aren't damaged at all makes it look a bit weird.

Also, this tile isn't possible
image

/mob/living/simple_animal/hostile/drakehound_breacher/Aggro()
. = ..()
if(target)
playsound(loc, 'sound/effects/unathihiss.ogg', 70, TRUE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, the death sounds very silly. i'd maybe have a look at it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the death sound sound/goonstation/voice/deathgasp_2.ogg is pitched up based on age... and simplemobs don't have ages.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map Sprites This PR modifies the game sprites labels Oct 11, 2024
@PollardTheDragon
Copy link
Contributor Author

is the claymore the one the chaplain gets? (if they even get one, i honestly forget)

No. It's a non-null rod claymore.

@PollardTheDragon
Copy link
Contributor Author

I'd suggest adding some /landmark/damageturf to some areas, given that the ship is very clearly damage, but the floor tiles aren't damaged at all makes it look a bit weird.

The tiles used are the burnt ones, but I'll add landmarks for damage.

Copy link
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial technical and design notes:

First off, I think it looks sick in-game. The pointy bits on the fore are interesting and maybe we could put turrets there.

2024_10_11__11_48_40__Paradise Station 13

2024_10_11__11_48_48__Paradise Station 13

Technical things:

  1. Resize your map so that there's only a one tile border of space surrounding it. Here appear to be the correct dimensions:

2024_10_11__12_17_07__paradise dme  unathi_skiff dmm  - StrongDMM

You can copy the whole thing, resize the map, and then paste it, since the map removes tiles from the top and right edges when getting smaller.

  1. Any area that's space and doesn't have any structures on it should be /area/space:

2024_10_11__12_20_51__paradise dme  unathi_skiff dmm  - StrongDMM

  1. Don't place terminals for power machines manually, the APC will auto-create them on init.

  2. Don't use the /turf/simulated/floor/plating/damaged or /turf/simulated/floor/plating/burnt subtypes (these shouldn't even exist), use /obj/effect/landmark/damageturf and /obj/effect/landmark/burnturf instead (but note those are going away in refactor: Migrate more random_spawners to random/spawners and mapping helpers. #27017 so after that gets merged you'll have to run the accompanying UpdatePaths script).

  3. Use the window spawners to place windows (in this case, /obj/effect/spawner/window/plastitanium instead of /obj/structure/window/full/plastitanium).

Design things:

  1. Because the APCs are drained, that means the ruin won't have power (duh) but that means that someone can enter it just by crowbarring the airlocks open. If you want to add a bit more of an obstacle to entry, you should power the APCs. And we should make a distinct access code for this ruin so that explorers can't waltz through the doors unimpeded.

  2. Because the windows are transparent, the breacher mobs can see players through them and will be aggroed at that point. And because their breacher weapons have such high object damage, they smash the windows pretty much instantly. Fighting simplemobs in space is much easier than on the ruin itself so you may either want to move the windows or the mobs so that the encounters occur on the ruin proper.

  3. All the airlocks facing space are hatches, which will cause everything to blow out to space when first opened. I would recommend 1) having fewer external airlocks and 2) using an appropriately shaped /obj/effect/spawner/airlock subtype as a primary external airlock, or some pod doors.

  4. The damaged turfs from the impact site look good, but the rest of the ship (aside from the trash spawners) looks very clean.

  5. The placement of the beds in the barracks feels a little arbitrary. I'm presuming this is some kind of regimented force; that suggests to me that the beds would be placed close together with less regard for personal space.

  6. The only seating is the one barstool, there should be enough places to sit as makes sense for the amount of crew, especialy in the cockpit, and so that they don't get slammed to the floor when the shuttle moves (hypothetical movement, obviously the ruin isn't going anywhere).

  7. The lack of decals in any of the rooms make them feel a little more spacious than they are. A handful of decals to indicate storage zones, or warning tape around external airlocks, would be good.

  8. There's no windows in the front of the cockpit, where it'd be sensible to have them.

  9. The change in floor tile color in the cockpit is a little abrupt, I'd use something like /obj/effect/turf_decal/siding to delineate them a bit:

2024_10_11__13_49_02__paradise dme  unathi_skiff dmm  - StrongDMM

(There's a tiny corner decal missing but we could create one for the sake of using it here)

  1. I believe the /turf/simulated/wall/mineral/iron you're using for the vault are much easier to break through than the plastitanium walls. While we can't make ruins 100% cheese-proof you may want to consider replacing these with walls that are harder to deconstruct.

  2. Unfortunately we don't have a lot of distinct tile/wallsets but I'd see if you can mix and match them to create something that feels culturally distinct for Unathi. The plastitanium walls and floors, and the internal hatch airlocks, are usually associated with the Syndicate. I don't know if the Unathi lore involves specific culturally significant colors or materials but something along those lines would help to make the ruin stand out.

Copy link
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized this girder is in space, it should have an /area/space/nearstation area:

2024_10_11__14_12_56__paradise dme  unathi_skiff dmm  - StrongDMM

@PollardTheDragon
Copy link
Contributor Author

Just realized this girder is in space, it should have an /area/space/nearstation area:

The girder (as well as the damage turfs mentioned above) have been handled in the most recent push, using landmarks to designate damaged tiles and fixing the missing plating there.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map Merge Conflict This PR is merge conflicted Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants