refactor/ci: enforce mapload in Initialize args #26878
Open
+171
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR adds
maploadto all atoms that should have it in its Initialize arguments, and adds a check_grep2 lint to enforce the rule, borrowed from /tg/.Why It's Good For The Game
maploadshould always be passed through to parent Initializes, otherwise code could run on mapload that shouldn't be.Testing
Built, ran CI, started a round and watched for any runtimes on roundstart. This isn't necessarily without side-effects since different codepaths could now be taken on Initialize. Not sure if it should be TMed for a round or two.
Declaration
Changelog
NPFC