Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleans up lighter code a tiny bit and fixes colored lighters becoming green #26129

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Spaghetti-bit
Copy link
Contributor

@Spaghetti-bit Spaghetti-bit commented Jul 2, 2024

What Does This PR Do

Fixes #23111

Why It's Good For The Game

Bugs bad.

Images of changes

image
image

Testing

Flicked a randomly colored lighter on and off, it stayed the same color.

Changelog

🆑
fix: Fixed lighters becoming green if they were not green before.
/:cl:

@Spaghetti-bit Spaghetti-bit added the Fix This PR will fix an issue in the game label Jul 2, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jul 3, 2024
Co-authored-by: Contrabang <[email protected]>
Signed-off-by: Spaghetti-bit <[email protected]>
Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cursed to me

Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if this still works for zippos

code/game/objects/items/weapons/lighters.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/lighters.dm Outdated Show resolved Hide resolved
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colored lighters become un-colored after usage.
4 participants