fix: strip '\improper' from request console names #26123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spaghetti-bit
approved these changes
Jul 2, 2024
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
ParadiseSS13-Bot
added
-Status: Awaiting review
Burzah
approved these changes
Jul 3, 2024
ParadiseSS13-Bot
added
-Status: Awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR removes the "\improper" escape character and any trailing/leading whitespace from request console names which are assigned their area's name. FWIW it doesn't seem like the
trimtext()call is absolutely necessary but better safe than sorry.Why It's Good For The Game
Secondary Goals are properly requested again.
Testing
Spawned in as bartender, requested secondary goal.
Changelog
馃啈
fix: Secondary goals are now correctly sent for all departments.
/:cl: