feat(dfu): impl codec #1234
Open
feat(dfu): impl codec #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#numberValue javadoc
Co-authored-by: MiniDigger | Martin <[email protected]>
…timization Use DecorationMap for style builder
…alue Add NumberBinaryTag#numberValue
feat(nbt): Add stream API for compound/list tags
Co-authored-by: Riley Park <[email protected]>
fix(minimessage): rename `numeric` to `string`
`mergeStyle` is called a lot, especially in TranslatableComponentRenderer, where there is no merging to be done. By skipping the creation of the builder if the merge is a no-op, we can save some allocations.
this will only break if someone has a minecraft key with a valid uuid value and they don't provide the namespace... but like, meh?
1.21.5 component changes
feature(minimessage): Set the target to hold the locale of the translation by default
…lder feature(api): Skip style builder creation on merge
feat(nbt): update number parsing for 1.21.5
feat(nbt): Initial implementation of heterogeneous list handling
Add `equals` to `VirtualComponent`
feature(api): Add a method to close an open dialog
…tener-pop-styles fix: component flattener not popping styles in correct order
These new modules are intended to allow better integration with the DFU library that drives a growing amount of serialization in modern Minecraft.
…ve DataComponentValueCodec
huanmeng-qwq
force-pushed
the
feat/dfu-codec
branch
from
b346b2f to
0f0594f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for this PR, I've completed the content according to the TODO comments. However, since I directly implemented the codec for Component using Gson as the intermediary, we might not need
TRANSLATION_ARGUMENT? I'm not sure—maybe this PR is just one possible implementation approach?