Refactor "Bump remaining tedious dependencies and misc. changes" back into Velocity#1794
Open
R00tB33rMan wants to merge 8 commits into
Open
Refactor "Bump remaining tedious dependencies and misc. changes" back into Velocity#1794R00tB33rMan wants to merge 8 commits into
R00tB33rMan wants to merge 8 commits into
Conversation
Member
|
The proxy module doesn't need javadocs, and I'm generally not inclined to mix a set of dependency bumps which are fair, with a javadoc coverage thing which needs a lot of scrutinsation to deal with properly this time. |
Contributor
Author
|
No problem, I'll go ahead and refactor this PR and split them up as well when I have the time! Takes a bit to reapply these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1718 was previously successfully merged, hence why I reimplemented my various dependency bumps. This time around, I went ahead and handwrote each Javadoc entry and change instead of feeding back AI-slop.
These changes have been extensively tested and should perform accordingly!