feat: Add primitive support for sound api #1422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Timongcraft
force-pushed
the
feature/sound-api
branch
from
4c5911e to
00d4dc6
Compare
Timongcraft
force-pushed
the
feature/sound-api
branch
from
192a88d to
e91c70a
Compare
Timongcraft
force-pushed
the
feature/sound-api
branch
from
e91c70a to
87b0e57
Compare
|
What is the state of this? I would like to have this feature very much. |
|
From my end, it is finished, although I would think it makes more sense to make the methods fail silently again. |
fix: implement the correct playSound method fix: bumped "since" version
|
We could also look into playing sounds from another player, but if so, I think that should be discussed first. |
|
@astei Could this be reviewed pls. |
4drian3d
approved these changes
Feb 22, 2025
|
@4drian3d Since it has been approved, can this also be merged? |
|
What is the state of this? We are currently discussing implementing this ourselves, but we would way prefer having it implemented in upstream. |
|
Apart from maybe adding Javadoc to the RegisteredServer, this PR is ready from my end. |
|
@4drian3d Do you think additional Javadoc entries are required? Is there an estimate when this might get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the Adventure-provided sound API is partially implemented.
It adds the ability to play sounds from a player (currently only for itself) and to stop sounds,
while making the methods fail silently if the sound can't played/stopped.
What this PR implements:
What this PR doesn't implement:
- A method to play back (custom) sounds for a specific player (at the player itself) for players with version 1.19.2 and below
- A method to stop (custom) sounds for players with version 1.19.2 and below
Clarification:
This PR only implements a sound API for version 1.19.3+ because only in this version is the server able to play a (vanilla) sound for a player without requiring a version-dependent id for the sound.