Clarify the functionality of AbstractVillager#resetOffers #13260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
approved these changes
Nov 1, 2025
Machine-Maker
approved these changes
Nov 1, 2025
github-project-automation
bot
moved this from Awaiting review
to Merged
in Paper PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with villagers, I noticed that calling
AbstractVillager#resetOfferswith normal villagers only adds two trades after resetting, even if the villager is not the base level and previously had more than two. I thought I had to use NMS to fix this, until I foundVillager#addTradesand realized I could add them through it. This PR clarifies howresetOffersworks and explains how the remaining trades can be added to a villager with the API.