Fix async command building throwing CME in some cases #13233
+18
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is from multiple places during that
sendAsyncprocess: Anything that loops through any CommandNode's children is subject to the CME.The previous fix was only working for the root node, and wasn't even fully working given a few lines lower it's being added in an HashMap, which does .hashCode and loops through the root's children again.
This PR reverts the previous fix and fixes the concurrency issue once for all:
Commands#fillUsableCommandsinside a synchronized block that uses the children map as lock object, the same lock object the synchronized map uses.This has been tested with the test plugin published on this branch of my fork
Fixes #11101