Skip to content

Conversation

mintychochip
Copy link

added method:

java.awt.Color MapPalette.getNearestColor(org.bukkit.Color);

@mintychochip mintychochip requested a review from a team as a code owner September 28, 2025 05:55
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Sep 28, 2025
@Warriorrrr Warriorrrr linked an issue Sep 28, 2025 that may be closed by this pull request
* @return the nearest {@link Color} from the map palette
*/
@NotNull
public static Color getNearestColor(@NotNull org.bukkit.Color color) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use an awt Color as the input, considering the rest of the file uses it already? I don't think mixing two different Colors is a good idea

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No yeah sorry, I initially thought the Color being referenced in the input parameter was a bukkit color

@Lulu13022002 Lulu13022002 changed the title Expose MapPallette.colors, Add MapPallette.getNearestColor #12907 Add MapPalette.getNearestColor Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

Expose MapPallette.colors, Add MapPallette.getNearestColor
2 participants