Fix inconsistencies between offline/online spawn position getter #11960
Conversation
| */ | ||
| @Nullable | ||
| public Location getRespawnLocation(); |
There was a problem hiding this comment.
I am wondering, what really is the rule for interfaces and explicit public modifiers? I have seen files/PRs with and I have seen files/PRs without.
There was a problem hiding this comment.
As far as I know, it was an unnecessary rule enforced by spigot.
Warriorrrr
added
type: bug
| /** | ||
| * Gets the Location where the player will spawn at, null if they | ||
| * don't have a valid respawn point. | ||
| * | ||
| * @return respawn location if exists, otherwise null. | ||
| */ |
There was a problem hiding this comment.
The Javadocs have been removed on this method. Is this intentional, or are you going to be adding different Javadocs soon?
There was a problem hiding this comment.
iirc it should now inherit from offline player?
There was a problem hiding this comment.
I don't think JDs are inherited by default?
There was a problem hiding this comment.
oh, no, nvm, they are, ineritDoc is for additive
Lulu13022002
force-pushed
the
fix/off-loc
branch
from
c02f0ef to
d7b2c43
Compare
|
This also fix Player#getRespawnLocation that consume the respawn anchor in the nether if binded |
Original: #8243
Also deprecated the old HumanEntity#getPotentialRespawnLocation since it doesn't track the respawn angle.