Updated Kyori-Adventure (4.17.0 -> 4.18.0) #11809
Merged
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
requested changes
Dec 24, 2024
paper-server/src/main/java/io/papermc/paper/adventure/AdventureCodecs.java
Outdated
Show resolved
Hide resolved
paper-server/src/main/java/io/papermc/paper/adventure/AdventureCodecs.java
Outdated
Show resolved
Hide resolved
|
Adoption of the shadow color looks good, we'll need to figure out what/how we need to support virtual components. |
|
Okay so, from my understanding, there is no need to adopt virtual components because we expect them to die on any interaction with the API and the server can/should just treat them as text component impl. |
lynxplay
approved these changes
Dec 27, 2024
Machine-Maker
approved these changes
Dec 27, 2024
lynxplay
force-pushed
the
updated-kyori-adventure
branch
from
089b67a to
5d7c607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies of Adventure + added test for shadow_color.