Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registry builders for SoundEvent and JukeboxSong #11805

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add registry builders for SoundEvent and JukeboxSong #11805

wants to merge 3 commits into from

Conversation

Machine-Maker
Copy link
Member

@Machine-Maker Machine-Maker commented Dec 24, 2024 •
edited
Loading

Draft until we decided that Either<L, R> is the way to go for the fluent getter at JukeboxSongRegistryEntry#soundEvent Either it is

Tasks
Preview Give feedback
  1. For new registry values, allow copying from existing #11796
    scope: api type: feature

@kennytv kennytv added the type: feature Request for a new Feature. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature Request for a new Feature.
Projects
Paper PR Queue
Status: Awaiting review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Machine-Maker @kennytv