Parity for respawn events #11792
Open
Parity for respawn events #11792
+128
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paper-api/src/main/java/io/papermc/paper/event/player/AbstractRespawnEvent.java
Outdated
Show resolved
Hide resolved
Lulu13022002
force-pushed
the
feat/respawn-events
branch
from
5875bf1 to
2436b63
Compare
Lulu13022002
force-pushed
the
feat/respawn-events
branch
from
2436b63 to
8cf7eab
Compare
Machine-Maker
approved these changes
Dec 24, 2024
kennytv
added
type: feature
Owen1212055
requested changes
Dec 27, 2024
Comment on lines
-59
to
-60
| public Location getRespawnLocation() { | ||
| return this.respawnLocation; |
There was a problem hiding this comment.
PlayerRespawnEvent supports mutability, this change removes that behavior as AbstractRespawnEvent clones it.
There was a problem hiding this comment.
This was discussed, there is a setter for the respawn location, so this is intential bulletproofing.
There was a problem hiding this comment.
I guess, just not sure about doing changes like these silently.
Owen1212055
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original: #8705
The RespawnReason should probably be moved into the super class later but require bytecode rewrite