Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlayerUseBowWithoutProjectileEvent #11774

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Chaosdave34
Copy link

@Chaosdave34 Chaosdave34 commented Dec 23, 2024

#11669

(Still dont have a better name for the event)

@Chaosdave34 Chaosdave34 requested a review from a team as a code owner December 23, 2024 00:04
Comment on lines 34 to 35
return item.clone();
}
Copy link
Member

@Owen1212055 Owen1212055 Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this event is only specific to bows, I think that this should be getBowItem() or something more specific

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tries to draw a bow or load a crossbow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to find a better name I guess, but certainly not related to bows xD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant bows, which applies to both crossbows/bow. But not sure, maybe leave as is then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess something like weapon item?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant you use anything as "bow" now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just getWeapon()?

@Chaosdave34
Copy link
Author

Chaosdave34 commented Dec 23, 2024

Maybe ProjectileWeaponItem, because thats the superclass of both bow and crossbow, although that's a really long name.

PlayerMissingProjectileItem?
PlayerMissingProjectileItemForProjectileWeaponItem?
PlayerMissingProjectileItemForWeapon?

(And isn't PlayerReadyArrowEvent confusing then, because its fired for crossbows and firework rockets aswell?)

… adjust javadocs, fix using old parameter name when calling event in Player#getProjectile
@kennytv kennytv added the type: feature Request for a new Feature. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Request for a new Feature.
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

5 participants