Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run player loot table for spectators #11464

Closed
wants to merge 10,000 commits into from

Conversation

Machine-Maker
Copy link
Member

@Machine-Maker Machine-Maker commented Oct 2, 2024

I think there's also an issue with spectators and xp dropping, but I can't test that out right now. Until I check that, this can be a draft.

Fixes #11463


Download the paperclip jar for this pull request: paper-11464.zip

@Machine-Maker Machine-Maker added the build-pr-jar Enables a workflow to build Paperclip jars on the pull request. label Oct 2, 2024
@Doc94
Copy link
Contributor

Doc94 commented Oct 3, 2024

I test and experience its not dropped in spectator mode but this is because the "keepLevel" behaviour use the same logic for keep is the keep inventory is true or the player is in spectator. also the "logic" for get how many exp need to be dropped is 0 for spectator but not sure from where comes that.. i just found a call for EnchantmentHelper.processMobExperience but not sure.

Lulu13022002 and others added 24 commits December 21, 2024 19:27
An incorrectly updated hunk attempted to remove the MobEffectInstance
from the active effect map instead of the Holder<MobEffect> as the
parameter name was changed from holder to effect during hardfork.
Also fixes an issue with direct holders
Came across this in my complete utter failure to use the commands to
apply patches properly
The existing logic in LivingEntity#checkTotemDeathProtection completes
by checking whether the death protection component is null or not.
In cases where the event was cancelled, the component needs to be nulled
out to prevent the method from returning true, causing the player to
properly die.
* Partially revert 083c083 for Transformation

The type is used in a way that requires mutability

* keep copy in ctors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-pr-jar Enables a workflow to build Paperclip jars on the pull request. pre-softspoon
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Spectators drop player loot table