-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run player loot table for spectators #11464
Closed
Machine-Maker
wants to merge
10,000
commits into
PaperMC:master
from
Machine-Maker:fix/player-loot-table
Closed
Don't run player loot table for spectators #11464
Machine-Maker
wants to merge
10,000
commits into
PaperMC:master
from
Machine-Maker:fix/player-loot-table
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
added
the
build-pr-jar
Enables a workflow to build Paperclip jars on the pull request.
label
Oct 2, 2024
I test and experience its not dropped in spectator mode but this is because the "keepLevel" behaviour use the same logic for keep is the keep inventory is true or the player is in spectator. also the "logic" for get how many exp need to be dropped is 0 for spectator but not sure from where comes that.. i just found a call for |
An incorrectly updated hunk attempted to remove the MobEffectInstance from the active effect map instead of the Holder<MobEffect> as the parameter name was changed from holder to effect during hardfork.
Also fixes an issue with direct holders
Came across this in my complete utter failure to use the commands to apply patches properly
The existing logic in LivingEntity#checkTotemDeathProtection completes by checking whether the death protection component is null or not. In cases where the event was cancelled, the component needs to be nulled out to prevent the method from returning true, causing the player to properly die.
* Partially revert 083c083 for Transformation The type is used in a way that requires mutability * keep copy in ctors
Machine-Maker
force-pushed
the
fix/player-loot-table
branch
from
December 24, 2024 01:21
fc9491a
to
9208365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's also an issue with spectators and xp dropping, but I can't test that out right now. Until I check that, this can be a draft.
Fixes #11463
Download the paperclip jar for this pull request: paper-11464.zip