Skip to content

Conversation

@wesbragagt
Copy link
Contributor

@wesbragagt wesbragagt commented Oct 10, 2025

Support building a custom postgres image in order to allow adding extensions for example pg_duckdb and pg_vector.

TODO:

  • Test in a real cluster

Important

Adds support for custom PostgreSQL images with extensions by introducing pg_custom_image variable and updating image selection logic.

  • Behavior:
    • Adds support for custom PostgreSQL images with extensions by introducing pg_custom_image variable in vars.tf.
    • Modifies imageName logic in main.tf to use pg_custom_image if set, otherwise defaults to pg_version.
  • Documentation:
    • Updates README.md with instructions for using pre-built and custom PostgreSQL images, including building custom images with Docker Bake.
    • Lists available extensions and provides warnings about using custom images.

This description was created by Ellipsis for 7459871. You can customize this summary. It will automatically update as commits are pushed.

@wesbragagt wesbragagt force-pushed the feat--kube-pg-cluster-support-custom-pg-containers branch from 7459871 to 146c14a Compare October 10, 2025 02:52
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 7459871 in 51 seconds. Click for details.
  • Reviewed 154 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/infrastructure/kube_pg_cluster/README.md:19
  • Draft comment:
    Custom image documentation looks clear and comprehensive. All examples and warnings are well presented.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. packages/infrastructure/kube_pg_cluster/main.tf:283
  • Draft comment:
    The conditional image selection using 'pg_custom_image' is correctly implemented. Consider also checking for an empty string in addition to null if that case is possible.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. packages/infrastructure/kube_pg_cluster/vars.tf:17
  • Draft comment:
    The 'pg_custom_image' variable is well documented. Optionally, add validation to ensure a non-empty string if provided.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_rKfQMIzrhWmfDLX7

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@fullykubed fullykubed merged commit 5809f90 into Panfactum:main Oct 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants