Fix method signature mismatch in Firewall subclass #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix exception due to method signature mismatch.
Motivation and Context
While using ansible at work last week I got an exception due to the Firewall.element() method not having the same method signature of the parent PanObject class. The PanObject.element() method has two optional kwargs that are used elsewhere. When a Firewall object was passed into one of those code paths that passed in one or both of the kwargs python thew an exception.
The kwargs are unused in the Firewall class and I'm unsure how those kwargs can be used.
How Has This Been Tested?
We have this package vendored into our repo at work so I patched it for now with the same change.
Screenshots (if appropriate)
Types of changes
Checklist