Skip to content

Fix method signature mismatch in Firewall subclass #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jonjitsu
Copy link

Description

Fix exception due to method signature mismatch.

Motivation and Context

While using ansible at work last week I got an exception due to the Firewall.element() method not having the same method signature of the parent PanObject class. The PanObject.element() method has two optional kwargs that are used elsewhere. When a Firewall object was passed into one of those code paths that passed in one or both of the kwargs python thew an exception.

The kwargs are unused in the Firewall class and I'm unsure how those kwargs can be used.

How Has This Been Tested?

We have this package vendored into our repo at work so I patched it for now with the same change.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant