Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address: Using pagerduty_alert_grouping_setting causes error HTTP response failed with status code 404 and no JSON error object was present #952

Merged

Conversation

imjaroiswebdev
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev commented Nov 11, 2024

Close #944

New test case introduce to protect from regressions...

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyAlertGroupingSetting_serviceNotExist -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/apiutil  [no test files]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     0.569s [no tests to run]
=== RUN   TestAccPagerDutyAlertGroupingSetting_serviceNotExist
--- PASS: TestAccPagerDutyAlertGroupingSetting_serviceNotExist (16.57s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       17.731s

go.mod Outdated Show resolved Hide resolved
@imjaroiswebdev imjaroiswebdev merged commit ff2374e into PagerDuty:master Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant