Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent timeout for alert_grouping_parameters to be explicitly set to zero when they are of type "content_based" #871

Merged
merged 1 commit into from
May 14, 2024

Conversation

cjgajard
Copy link
Contributor

@cjgajard cjgajard commented May 14, 2024

Fixes issue #867

New acceptance test introduced to prevent regression

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyService_AlertGroupingParametersAddConfigField -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
=== RUN   TestAccPagerDutyService_AlertGroupingParametersAddConfigField
--- PASS: TestAccPagerDutyService_AlertGroupingParametersAddConfigField (21.31s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     21.978s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       1.147s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  0.780s [no tests to run]

Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @cjgajard! Thank you addressing this 🎉 💪🏽

@imjaroiswebdev imjaroiswebdev merged commit 819a07c into PagerDuty:master May 14, 2024
1 check passed
@cjgajard cjgajard deleted the issue-867 branch May 20, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants