Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSGI-2268 ] Deprecate integration_key attribute mutation for Service Integrations #775

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[CSGI-2268 ] Deprecate integration_key attribute mutation for Service Integrations #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pagerduty/resource_pagerduty_service_integration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,10 @@ func resourcePagerDutyServiceIntegration() *schema.Resource {
Computed: true,
},
"integration_key": {
Type: schema.TypeString,
Optional: true,
Computed: true,
Type: schema.TypeString,
Optional: true,
Computed: true,
Deprecated: "Assignments or updates to this attribute are not supported by Service Integrations API, it is a read-only value. Input support will be dropped in upcomming major release",
},
"integration_email": {
Type: schema.TypeString,
Expand Down
3 changes: 1 addition & 2 deletions website/docs/r/service_integration.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ resource "pagerduty_service_integration" "example" {
resource "pagerduty_service_integration" "apiv2" {
name = "API V2"
type = "events_api_v2_inbound_integration"
integration_key = "12345678910testtesttesttesttes"
service = pagerduty_service.example.id
}

Expand Down Expand Up @@ -166,7 +165,7 @@ The following arguments are supported:
To integrate with a **vendor** (e.g. Datadog or Amazon Cloudwatch) use the `vendor` field instead.

* `vendor` - (Optional) The ID of the vendor the integration should integrate with (e.g. Datadog or Amazon Cloudwatch).
* `integration_key` - (Optional) This is the unique key used to route events to this integration when received via the PagerDuty Events API.
* `integration_key` - (Optional) (Deprecated) This is the unique key used to route events to this integration when received via the PagerDuty Events API.
* `integration_email` - (Optional) This is the unique fully-qualified email address used for routing emails to this integration for processing.

* `email_incident_creation` - (Optional) Behaviour of Email Management feature ([explained in PD docs](https://support.pagerduty.com/docs/email-management-filters-and-rules#control-when-a-new-incident-or-alert-is-triggered)). Can be `on_new_email`, `on_new_email_subject`, `only_if_no_open_incidents` or `use_rules`.
Expand Down
Loading