Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSGI-2093] Patch - Service Orchestration enable status doesn't opt in #769

Merged

Conversation

imjaroiswebdev
Copy link
Contributor

Test cases extended...

$ make testacc TESTARGS="-run TestAccPagerDutyEventOrchestration"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyEventOrchestration -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyEventOrchestrationIntegration_import
--- PASS: TestAccPagerDutyEventOrchestrationIntegration_import (8.89s)
=== RUN   TestAccPagerDutyEventOrchestrationPathGlobal_import
--- PASS: TestAccPagerDutyEventOrchestrationPathGlobal_import (13.50s)
=== RUN   TestAccPagerDutyEventOrchestrationPathRouter_import
--- PASS: TestAccPagerDutyEventOrchestrationPathRouter_import (16.98s)
=== RUN   TestAccPagerDutyEventOrchestrationPathService_import
--- PASS: TestAccPagerDutyEventOrchestrationPathService_import (15.16s)
=== RUN   TestAccPagerDutyEventOrchestrationPathUnrouted_import
--- PASS: TestAccPagerDutyEventOrchestrationPathUnrouted_import (15.75s)
=== RUN   TestAccPagerDutyEventOrchestration_import
--- PASS: TestAccPagerDutyEventOrchestration_import (8.64s)
=== RUN   TestAccPagerDutyEventOrchestrationNameOnly_import
--- PASS: TestAccPagerDutyEventOrchestrationNameOnly_import (5.25s)
=== RUN   TestAccPagerDutyEventOrchestrationIntegration_Basic
--- PASS: TestAccPagerDutyEventOrchestrationIntegration_Basic (33.56s)
=== RUN   TestAccPagerDutyEventOrchestrationPathGlobal_Basic
--- PASS: TestAccPagerDutyEventOrchestrationPathGlobal_Basic (78.60s)
=== RUN   TestAccPagerDutyEventOrchestrationPathRouter_Basic
--- PASS: TestAccPagerDutyEventOrchestrationPathRouter_Basic (67.69s)
=== RUN   TestAccPagerDutyEventOrchestrationPathService_Basic # 👈 Test case extended
--- PASS: TestAccPagerDutyEventOrchestrationPathService_Basic (140.49s)
=== RUN   TestAccPagerDutyEventOrchestrationPathUnrouted_Basic
--- PASS: TestAccPagerDutyEventOrchestrationPathUnrouted_Basic (58.41s)
=== RUN   TestAccPagerDutyEventOrchestration_Basic
--- PASS: TestAccPagerDutyEventOrchestration_Basic (22.38s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   485.809s

Copy link
Contributor

@alenapan alenapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left non-blocking comment about combining two expressions into one, otherwise LGTM 👍

@imjaroiswebdev imjaroiswebdev merged commit 3cdf794 into PagerDuty:master Nov 15, 2023
1 check passed
@imjaroiswebdev imjaroiswebdev deleted the serv-orch-toggle-doesnt-optin branch November 15, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants