Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSGI-2016] Address pagerduty_schedule validation error on weekly restriction wihtout Start of week day #764

Conversation

imjaroiswebdev
Copy link
Contributor

When a pagerduty_schedule layer is configured with a weekly_restriction type, without setting a start_day_of_week a validation error will be returned during planning stage, like the following...

╷
│ Error: start_day_of_week must be set for a weekly_restriction schedule restriction type

Test case extended...

$ make testacc TESTARGS="-run TestAccPagerDutySchedule_Basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutySchedule_Basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutySchedule_Basic # 👈 Test case extended
--- PASS: TestAccPagerDutySchedule_Basic (28.08s)
=== RUN   TestAccPagerDutySchedule_BasicWithExternalDestroyHandling
--- PASS: TestAccPagerDutySchedule_BasicWithExternalDestroyHandling (15.25s)
=== RUN   TestAccPagerDutySchedule_BasicWeek
--- PASS: TestAccPagerDutySchedule_BasicWeek (17.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   61.092s

@imjaroiswebdev imjaroiswebdev merged commit 7634a17 into PagerDuty:master Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant