add missing properties to incident_custom_field resource documentation #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imjaroiswebdev FYI - this is a purely docs change. Not sure if there is a way to publish this without doing a formal release. |
imjaroiswebdev
force-pushed
the
issue/correct-custom-fields-documentation
branch
from
290bbb8 to
c19de50
Compare
imjaroiswebdev
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Hey @jedelson-pagerduty thank you for adding this necessary update to the docs. I took the liberty of rebasing your changes for a clean merge btw ✌🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that in executing the series of changes related to the
incident_custom_fieldresource, the documentation ended up in a state where a subset of properties were omitted. Of chief import is that thedisplay_nameproperty is not documented -- this is required and thus really important to have documented correctly.Closes #767