-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ORCA-4263] Support for incident custom fields for Event Orchestration #749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a question in the markdown file, otherwise LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vendored dependencies should be updated to reflect latest changes on heimweh/go-pagerduty#139, otherwise LGTM 👍🏽
vendor/github.com/heimweh/go-pagerduty/pagerduty/event_orchestration_path.go
Outdated
Show resolved
Hide resolved
da691f6
to
145834d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
This PR adds support for incident custom fields on event orchestration.
Changes:
incident_custom_field_update
action on Event Orchestration.Notice: Custom Fields on Event Orchestration are not available in production. This will need appropriate permission to apply correctly when it is released (ETA Jan/Feb 2024).
Example stack which uses the new custom field. This can be run today but will produce a warning.