Fix service update conflict on alert grouping rules

PagerDuty · Dec 24, 2024 · e4a4daa · e4a4daa
1 parent 403797b
commit e4a4daa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/pagerduty/resource_pagerduty_service.go b/pagerduty/resource_pagerduty_service.go
@@ -418,7 +418,9 @@ func buildServiceStruct(d *schema.ResourceData) (*pagerduty.Service, error) {
 
 	if attr, ok := d.GetOk("alert_grouping"); ok {
 		ag := attr.(string)
-		service.AlertGrouping = &ag
+		if ag != "rules" {
+			service.AlertGrouping = &ag
+		}
 	}
 
 	if attr, ok := d.GetOk("alert_grouping_parameters"); ok {
@@ -525,6 +527,10 @@ func resourcePagerDutyServiceCreate(d *schema.ResourceData, meta interface{}) er
 
 	d.SetId(service.ID)
 
+	// We wait for internal subsystem to sync. Otherwise fields like
+	// alert_grouping_parameters will return empty.
+	time.Sleep(500 * time.Millisecond)
+
 	return fetchService(d, meta, genError)
 }
 

diff --git a/pagerduty/resource_pagerduty_service_test.go b/pagerduty/resource_pagerduty_service_test.go
@@ -406,7 +406,7 @@ func TestAccPagerDutyService_AlertGrouping(t *testing.T) {
 	// and will be removed in a future release.
 }
 
-func TestAccPagerDutyService_AlertContentGrouping(t *testing.T) {
+func TestAccPagerDutyService_AlertGroupingContentBased(t *testing.T) {
 	username := fmt.Sprintf("tf-%s", acctest.RandString(5))
 	email := fmt.Sprintf("%[email protected]", username)
 	escalationPolicy := fmt.Sprintf("tf-%s", acctest.RandString(5))