Merge pull request #928 from imjaroiswebdev/issue-904-repatch

Second attempt to address: API calls cancelled by client because of Timeout
PagerDuty · Aug 23, 2024 · 44667a7 · 44667a7
2 parents 60e9dd0 + e0522f5
commit 44667a7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 27 deletions.
diff --git a/pagerduty/config.go b/pagerduty/config.go
@@ -76,17 +76,9 @@ func (c *Config) Client() (*pagerduty.Client, error) {
 
 	var httpClient *http.Client
 	httpClient = http.DefaultClient
-	httpClient.Timeout = 2 * time.Minute
+	httpClient.Timeout = 30 * time.Second
 
 	transport := http.DefaultTransport.(*http.Transport).Clone()
-	// Set the maximum number of idle (keep-alive) connections across all hosts
-	// Experimenting with these values to see if it helps with the connection pool
-	// and hence to solve the issue
-	// https://github.com/PagerDuty/terraform-provider-pagerduty/issues/904
-	transport.MaxIdleConns = 0
-	transport.MaxIdleConnsPerHost = 500
-	transport.MaxConnsPerHost = 0
-
 	if c.InsecureTls {
 		transport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
 	}
@@ -150,17 +142,9 @@ func (c *Config) SlackClient() (*pagerduty.Client, error) {
 
 	var httpClient *http.Client
 	httpClient = http.DefaultClient
-	httpClient.Timeout = 2 * time.Minute
+	httpClient.Timeout = 30 * time.Second
 
 	transport := http.DefaultTransport.(*http.Transport).Clone()
-	// Set the maximum number of idle (keep-alive) connections across all hosts
-	// Experimenting with these values to see if it helps with the connection pool
-	// and hence to solve the issue
-	// https://github.com/PagerDuty/terraform-provider-pagerduty/issues/904
-	transport.MaxIdleConns = 0
-	transport.MaxIdleConnsPerHost = 500
-	transport.MaxConnsPerHost = 0
-
 	if c.InsecureTls {
 		transport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
 	}

diff --git a/pagerdutyplugin/config.go b/pagerdutyplugin/config.go
@@ -76,17 +76,9 @@ func (c *Config) Client(ctx context.Context) (*pagerduty.Client, error) {
 	}
 
 	httpClient := http.DefaultClient
-	httpClient.Timeout = 2 * time.Minute
+	httpClient.Timeout = 30 * time.Second
 
 	transport := http.DefaultTransport.(*http.Transport).Clone()
-	// Set the maximum number of idle (keep-alive) connections across all hosts
-	// Experimenting with these values to see if it helps with the connection pool
-	// and hence to solve the issue
-	// https://github.com/PagerDuty/terraform-provider-pagerduty/issues/904
-	transport.MaxIdleConns = 0
-	transport.MaxIdleConnsPerHost = 500
-	transport.MaxConnsPerHost = 0
-
 	if c.InsecureTls {
 		transport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
 	}