address PR feedback

PagerDuty · Nov 11, 2024 · 2482d66 · 2482d66
1 parent aa93eab
commit 2482d66
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/pagerduty/data_source_pagerduty_automation_actions_action_test.go b/pagerduty/data_source_pagerduty_automation_actions_action_test.go
@@ -75,7 +75,7 @@ resource "pagerduty_automation_actions_action" "test" {
 		process_automation_job_arguments = "-arg 1"
 		process_automation_node_filter = "tags: production"
 	  }
-	only_invocable_on_unresolved_incidents: true
+	only_invocable_on_unresolved_incidents = true
 }
 
 data "pagerduty_automation_actions_action" "foo" {

diff --git a/pagerduty/resource_pagerduty_automation_actions_action.go b/pagerduty/resource_pagerduty_automation_actions_action.go
@@ -163,6 +163,9 @@ func buildAutomationActionsActionStruct(d *schema.ResourceData) (*pagerduty.Auto
 		automationActionsAction.OnlyInvocableOnUnresolvedIncidents = &val
 	}
 
+	attr, _ := d.Get("only_invocable_on_unresolved_incidents").(bool)
+	automationActionsAction.OnlyInvocableOnUnresolvedIncidents = &attr
+
 	return &automationActionsAction, nil
 }
 
@@ -310,7 +313,7 @@ func resourcePagerDutyAutomationActionsActionRead(d *schema.ResourceData, meta i
 			}
 
 			if automationActionsAction.OnlyInvocableOnUnresolvedIncidents != nil {
-				d.Set("only_invocable_on_unresolved_incidents", &automationActionsAction.OnlyInvocableOnUnresolvedIncidents)
+				d.Set("only_invocable_on_unresolved_incidents", *automationActionsAction.OnlyInvocableOnUnresolvedIncidents)
 			}
 		}
 		return nil

diff --git a/pagerduty/resource_pagerduty_automation_actions_action_test.go b/pagerduty/resource_pagerduty_automation_actions_action_test.go
@@ -85,7 +85,7 @@ func TestAccPagerDutyAutomationActionsActionTypeProcessAutomation_Basic(t *testi
 					resource.TestCheckResourceAttrSet("pagerduty_automation_actions_action.foo", "modify_time"),
 					resource.TestCheckResourceAttrSet("pagerduty_automation_actions_action.foo", "runner_id"),
 					resource.TestCheckResourceAttr("pagerduty_automation_actions_action.foo", "runner_type", "runbook"),
-					resource.TestCheckResourceAttr("pagerduty_automation_actions_action.foo", "only_invocable_on_unresolved_incidents", "true"),
+					resource.TestCheckResourceAttr("pagerduty_automation_actions_action.foo", "only_invocable_on_unresolved_incidents", "false"),
 				),
 			},
 		},
@@ -218,7 +218,7 @@ resource "pagerduty_automation_actions_action" "foo" {
 		process_automation_job_id = "pa_job_id_123"
 		process_automation_job_arguments = "-arg 1"
 		process_automation_node_filter = "tags: production"
-	  },
+	  }
 	only_invocable_on_unresolved_incidents = "true"
 }
 `, actionName, actionName)