-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.0.0 Replace Requests with HTTPX #145
Open
Deconstrained
wants to merge
12
commits into
main
Choose a base branch
from
v6.0.0-replace-requests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecate the "prepare_headers" method * Add a new "default_headers" property to take its place (this simplifies the developer interface)
…x support them any longer)
Deconstrained
force-pushed
the
v6.0.0-replace-requests
branch
from
November 20, 2024 17:04
aedc91c
to
19405f4
Compare
Note on test failures: the second to-do item above should take care of them, because the library currently makes the assumption that the local environment has urllib3 by virtue of installing requests (it's a second-removed upstream dependency). |
…pe of the client documentation
…ests.Session.request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
Long-term, we are looking to add support for thread safety, i.e. to fulfill #132. This requires switching the HTTP client on which pdpyras is based to one that is thread-safe. HTTPX is thread-safe and provides an interface that is very similar to that of Requests, and so minimal changes will be necessary in order to adopt it. Moreover, it optionally supports HTTP/2 which gives us the option of supporting that protocol in the future as well. Finally, allegations regarding how the maintainers of Requests have responded to responsible security disclosures give us pause, and compel us to switch out the base HTTP client for the benefit of PagerDuty customers' security.
Summary of Changes
requests.Session
withhttpx.Client
andrequests.Response
withhttpx.Response
To-do
content-type: application/json
won't mess with how query parameters are interpreted and thus that it is safe to proceed with the simplification that pays off a bit of tech debt