Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding proper types for Links and Images #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daniellockard
Copy link

I think this is correct? It should make code easier to write instead of writing something like

Links: []interface{}{
			map[string]string{
				"href": "https://link.to.thing/thing",
				"text": "Link",
			},
		},

@theckman
Copy link
Collaborator

@daniellockard to confirm: would this is would result in a compile-time breaking API change?

@theckman theckman added the open question there is an open question on the issue / PR label Feb 20, 2021
@theckman theckman added this to the v2.0.0 milestone Feb 20, 2021
@daniellockard
Copy link
Author

This PR was opened quite some time ago. I haven't actually looked at pagerduty anything in quite some time. I believe it would as it changes the types of images and links to actual types.

@theckman
Copy link
Collaborator

@daniellockard thank you for taking the time to comment. That makes sense, and I'll keep this PR on-deck for whenever we look to release v2.0.0. Thank you for the contribution, and I apologize for it taking so long to get some sort of resolution on this.

@theckman theckman removed the open question there is an open question on the issue / PR label Feb 23, 2021
@theckman theckman added the breaking change This PR contains a breaking change label Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This PR contains a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants