-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon 7th No.35】为 Paddle 代码转换工具新增 API 转换规则(第 2 组)-part #6880
Conversation
ccsuzzh
commented
Sep 18, 2024
- 【Hackathon 7th】开源贡献个人挑战赛 Paddle#68244
感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6880.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
大量映射不正确。
建议对Paddle API充分调研下,直接下一份源码在代码里搜索,或者import 下paddle动手尝试后再写。
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.addbmm_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.addcdiv_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.addmv_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.addr_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.baddbmm_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.mul_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.sinc_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.t_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.transpose_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.xlogy_.md
Outdated
Show resolved
Hide resolved
@ccsuzzh 这个还未修改,需要针对每个API,找到最合适的映射 |
目前还剩下几个API没有用inplace api组合实现,因为无法满足需要广播的情况,而PyTorch是支持的,需要全部改成inplace api组合实现吗? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
全部需要用inplace来组合。
提交文档时,你同时提交paconvert的matcher和单测吧,实际运行测一下
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.addbmm_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.addbmm_.md
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.erfc_.md
Outdated
Show resolved
Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/Tensor/torch.Tensor.int_repr.md
Outdated
Show resolved
Hide resolved
@ccsuzzh Matcher和单测看起来基本都是正确的了,把文档也同步下吧,文档和Matcher需要对齐一致 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM