Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 7th No.36】为 Paddle 代码转换工具新增 API 转换规则（第 3 组） -part #6879

Merged
merged 13 commits into from
Sep 29, 2024
Merged

【Hackathon 7th No.36】为 Paddle 代码转换工具新增 API 转换规则（第 3 组） -part #6879

merged 13 commits into from
Sep 29, 2024

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Sep 18, 2024

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Sep 18, 2024

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-6879.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：飞桨文档预览工具

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@luotao1 luotao1 mentioned this pull request Sep 18, 2024
Open
@luotao1 luotao1 added the PaddlePaddle Hackathon 飞桨黑客松活动issue与PR label Sep 19, 2024
@enkilee enkilee mentioned this pull request Sep 19, 2024
Merged
zhwesky2010
zhwesky2010 reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意对应到公开API

zhwesky2010
zhwesky2010 reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个没有修改吧，对应到这个API：https://www.paddlepaddle.org.cn/documentation/docs/zh/2.6/api/paddle/audio/functional/get_window_cn.html#get-window

@enkilee
Copy link
Contributor Author

enkilee commented Sep 23, 2024

这个没有修改吧，对应到这个API：https://www.paddlepaddle.org.cn/documentation/docs/zh/2.6/api/paddle/audio/functional/get_window_cn.html#get-window

ok，已改

zhwesky2010
zhwesky2010 reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这边看到修改后的内容，是反向错误修改的
infoflow 2024-09-24 16-40-31

_xx 是非公开API，要用无下划线API

@enkilee enkilee mentioned this pull request Sep 25, 2024
Merged
zhwesky2010
zhwesky2010 reviewed Sep 27, 2024
View reviewed changes
...onvert/convert_from_pytorch/api_difference/audio/functional/torch.signal.windows.blackman.md Outdated Show resolved Hide resolved
...onvert/convert_from_pytorch/api_difference/audio/functional/torch.signal.windows.blackman.md Outdated Show resolved Hide resolved
...onvert/convert_from_pytorch/api_difference/audio/functional/torch.signal.windows.blackman.md Outdated Show resolved Hide resolved
..._convert/convert_from_pytorch/api_difference/audio/functional/torch.signal.windows.cosine.md Outdated Show resolved Hide resolved
..._convert/convert_from_pytorch/api_difference/audio/functional/torch.signal.windows.cosine.md Outdated Show resolved Hide resolved
...convert_from_pytorch/api_difference/audio/functional/torch.signal.windows.general_hamming.md Outdated Show resolved Hide resolved
...convert/convert_from_pytorch/api_difference/audio/functional/torch.signal.windows.hamming.md Outdated Show resolved Hide resolved
...convert/convert_from_pytorch/api_difference/audio/functional/torch.signal.windows.hamming.md Outdated Show resolved Hide resolved
...el_convert/convert_from_pytorch/api_difference/audio/functional/torch.signal.windows.hann.md Outdated Show resolved Hide resolved
...el_convert/convert_from_pytorch/api_difference/audio/functional/torch.signal.windows.hann.md Outdated Show resolved Hide resolved
zhwesky2010
zhwesky2010 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

注意事项：

  1. 后续根据该文档来实现Matcher，注意不要出现文档与Matcher的diff。
  2. 如果实现Matcher的过程中，发现文档有误，需及时回头更正文档。

@zhwesky2010 zhwesky2010 merged commit eb8388f into PaddlePaddle:develop Sep 29, 2024
2 checks passed
@luotao1 luotao1 changed the title 【Hackathon 7th No.36】为 Paddle 代码转换工具新增 API 转换规则（第 3 组） part 1 【Hackathon 7th No.36】为 Paddle 代码转换工具新增 API 转换规则（第 3 组） -part Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

@luotao1 luotao1

@zhwesky2010 zhwesky2010

@sunzhongkai588 sunzhongkai588

Labels
contributor PaddlePaddle Hackathon 飞桨黑客松活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enkilee @CLAassistant @zhwesky2010 @luotao1 @sunzhongkai588