Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组）-part #6878

Merged
merged 10 commits into from
Sep 25, 2024
Merged

【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组）-part #6878

merged 10 commits into from
Sep 25, 2024

Conversation

Asthestarsfalll
Copy link
Contributor

@Asthestarsfalll Asthestarsfalll commented Sep 18, 2024 •
edited
Loading

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Sep 18, 2024

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-6878.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：飞桨文档预览工具

@luotao1 luotao1 mentioned this pull request Sep 18, 2024
Open
@luotao1 luotao1 added the PaddlePaddle Hackathon 飞桨黑客松活动issue与PR label Sep 18, 2024
@zhwesky2010 zhwesky2010 mentioned this pull request Sep 18, 2024
Merged
zhwesky2010
zhwesky2010 reviewed Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦根据 文档模板规范https://github.com/PaddlePaddle/docs/blob/develop/docs/guides/model_convert/convert_from_pytorch/pytorch_api_mapping_format_cn.md ， 一一核对并检查无误。

不符合文档规范，不予合入

...odel_convert/convert_from_pytorch/api_difference/functional/torch.nn.functional.lp_pool1d.md Outdated Show resolved Hide resolved
...odel_convert/convert_from_pytorch/api_difference/functional/torch.nn.functional.lp_pool2d.md Outdated Show resolved Hide resolved
...odel_convert/convert_from_pytorch/api_difference/functional/torch.nn.functional.lp_pool1d.md Outdated Show resolved Hide resolved
...odel_convert/convert_from_pytorch/api_difference/functional/torch.nn.functional.lp_pool2d.md Outdated Show resolved Hide resolved
.../model_convert/convert_from_pytorch/api_difference/nn/torch.nn.AdaptiveLogSoftmaxWithLoss.md Outdated Show resolved Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/nn/torch.nn.Softmin.md Show resolved Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/nn/torch.nn.Softmin.md Outdated Show resolved Hide resolved
...onvert/convert_from_pytorch/api_difference/nn/torch.nn.utils.parametrizations.weight_norm.md Outdated Show resolved Hide resolved
...onvert/convert_from_pytorch/api_difference/nn/torch.nn.utils.parametrizations.weight_norm.md Outdated Show resolved Hide resolved
docs/guides/model_convert/convert_from_pytorch/api_difference/optimizer/torch.optim.RAdam.md Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Asthestarsfalll
Asthestarsfalll commented Sep 18, 2024
View reviewed changes
Copy link
Contributor Author

@Asthestarsfalll Asthestarsfalll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已按照文档要求更新，劳烦再审核下

docs/guides/model_convert/convert_from_pytorch/api_difference/nn/torch.nn.Softmin.md Show resolved Hide resolved
@zhwesky2010
Copy link
Collaborator

@Asthestarsfalll 映射文档有问题，未通过CI不予合入：

1394 mapping documents found in api_difference.
2024-09-18 21:37:29 16 mapping documents found in api_difference_third_party/transformers.
2024-09-18 21:37:29 7 mapping documents found in api_difference_third_party/fairscale.
2024-09-18 21:37:29 4 mapping documents found in api_difference_third_party/flash_attn.
2024-09-18 21:37:29 Traceback (most recent call last):
2024-09-18 21:37:29   File "/FluidDoc/docs/guides/model_convert/convert_from_pytorch/tools/apply_references.py", line 319, in <module>
2024-09-18 21:37:29     metas = discover_all_metas(cfp_basedir)
2024-09-18 21:37:29   File "/FluidDoc/docs/guides/model_convert/convert_from_pytorch/tools/validate_mapping_files.py", line 635, in discover_all_metas
2024-09-18 21:37:29     metas.append(get_meta_from_diff_file(f, s, d, src_argmap_title=sh))
2024-09-18 21:37:29   File "/FluidDoc/docs/guides/model_convert/convert_from_pytorch/tools/validate_mapping_files.py", line 208, in get_meta_from_diff_file
2024-09-18 21:37:29     raise ValueError(
2024-09-18 21:37:29 ValueError: Unexpected mapping type: Paddle ???????????? in /FluidDoc/docs/guides/model_convert/convert_from_pytorch/tools/../api_difference/functional/torch.nn.functional.lp_pool2d.md
2024-09-18 21:37:29 Error: API mapping generate script failed, please check changes in /FluidDoc/docs/guides/model_convert/convert_from_pytorch

zhwesky2010
zhwesky2010 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，后续根据该文档来实现Matcher吧，注意不要出现文档与Matcher的diff。
如果实现Matcher的过程中，发现文档有误，需及时更正文档。

@luotao1 luotao1 changed the title 【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组） 【Hackathon 7th No.39】为 Paddle 代码转换工具新增 API 转换规则（第 6 组）-part Sep 24, 2024
@luotao1 luotao1 merged commit 893646d into PaddlePaddle:develop Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

@luotao1 luotao1

@zhwesky2010 zhwesky2010

@sunzhongkai588 sunzhongkai588

Labels
contributor PaddlePaddle Hackathon 飞桨黑客松活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Asthestarsfalll @CLAassistant @zhwesky2010 @luotao1 @sunzhongkai588