Skip to content

Conversation

@llbdyiu66
Copy link
Collaborator

No description provided.

@paddle-bot
Copy link

paddle-bot bot commented Dec 10, 2025

Thanks for your contribution!

lugimzzz
lugimzzz previously approved these changes Dec 10, 2025
Copy link
Collaborator

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JunnYu JunnYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要修改

)

return actions
if config.tie_word_embeddings:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里没有tie_word_embeddings的概念了吧?formers默认是 base_actions["lm_head.weight"] = partial(fn, is_column=False) 这个吧

final_actions = {}

base_actions = {
"lm_head.weight": partial(fn, is_column=True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial(fn, is_column=False)


mappings = make_base_actions()

if config.tie_word_embeddings:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上


LAYER_ROWWISE = ["self_attn.o_proj.weight"]
base_actions = {
"lm_head.weight": partial(fn, is_column=True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@JunnYu
Copy link
Member

JunnYu commented Dec 10, 2025

完善PR描述内容,新增测试等。
image

{
f"{cls.base_model_prefix}.layers.{layer_idx}.mlp.experts.{e}.{k}": partial(
fn, is_column=True
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuse_attention_ffn的时候需要输入 is_naive_2fuse=True

for k in LAYER_COLWISE
}
)
# colwise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少fuse ffn, 然后注意 is_naive_2fuse 的添加

"mlp.gate_proj.weight",
]

FUSE_LAYER_COLWISE = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全缺少 is_naive_2fuse

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 55.20833% with 86 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@4e7b961). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/transformers/qwen2_moe/modeling.py 53.84% 24 Missing ⚠️
paddleformers/transformers/qwen3_moe/modeling.py 56.00% 22 Missing ⚠️
paddleformers/transformers/qwen3/modeling.py 54.34% 21 Missing ⚠️
paddleformers/transformers/qwen2/modeling.py 56.81% 19 Missing ⚠️

❌ Your patch status has failed because the patch coverage (55.20%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3150   +/-   ##
==========================================
  Coverage           ?   36.74%           
==========================================
  Files              ?      416           
  Lines              ?    71324           
  Branches           ?        0           
==========================================
  Hits               ?    26207           
  Misses             ?    45117           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants