🚀Fix: [Config] Prevent Attribute Overwrite in PretrainedConfig.__init__ #3128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Summary of Changes
Refactor PretrainedConfig.init: Switched the signature from generic def init(self, **kwargs) to one that explicitly lists all common parameters (use_cache, return_dict, tie_word_embeddings, etc.).
Fix Attribute Overwrite (The Bug): preventing the parent class from using its hardcoded default (False) to overwrite values already set or explicitly passed by the subclass (e.g., Qwen3Config).
Preserved Custom Logic: All existing paddleformers specific logic (e.g., LlmMetaConfig initialization, fuse_ flags, quantization_config handling) remains intact and is correctly processed via kwargs.pop after the standard attributes are assigned.