Skip to content

Conversation

WYB27
Copy link
Collaborator

@WYB27 WYB27 commented Sep 20, 2025

改动:

  1. 修复attn_mask_startend_row_indices没有正确传入的问题
  2. 修复开启use_fused_head_and_loss_fn后转置参数传递错误的问题

Copy link

paddle-bot bot commented Sep 20, 2025

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@dc9ac0e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/transformers/glm4_moe/modeling.py 0.00% 3 Missing ⚠️
paddleformers/trl/model_config.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2648   +/-   ##
==========================================
  Coverage           ?   29.52%           
==========================================
  Files              ?      311           
  Lines              ?    54249           
  Branches           ?        0           
==========================================
  Hits               ?    16017           
  Misses             ?    38232           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

model_config.num_nextn_predict_layers = model_args.num_nextn_predict_layers
model_config._attn_implementation = model_args.attn_impl
if training_args.use_expert_parallel and training_args.expert_parallel_degree >= 1:
model_config.n_group = training_args.expert_parallel_degree
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model_config.n_group 不是每个模型都叫n_group,看看怎么处理通用化一些

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants