-
Notifications
You must be signed in to change notification settings - Fork 753
swa #8054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhoutianzi666
wants to merge
1
commit into
PaddlePaddle:develop
Choose a base branch
from
zhoutianzi666:support_swa_mha1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−2
Open
swa #8054
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Bug 这里把
window_size固定为-1,导致新增的 SWA mask 分支不会在唯一调用点生效。Attention层已经在layer_types == "sliding_attention"时保存了layer.sliding_window,append_attn_backend也会把正的sliding_window传给 attention kernel;但 SM10 的 MLA mixed prefill 会走这个mha_baseline分支,当前固定-1后即使该层是 sliding attention,也会执行 full causal attention,输出语义和 SWA 配置不一致。建议修复方式:在调用前按现有 attention 约定计算当前层窗口,例如 sliding 层传
layer.sliding_window(或与 append backend 一致地优先使用 backend/model 级self.sliding_window),非 sliding 层传-1/0表示 full attention,并补充kv_len > q_len的 mixed prefill + SWA 对齐测试。