-
Notifications
You must be signed in to change notification settings - Fork 753
Revert blockwise CUDAGraph and support piecewise CUDAGraph in prefill #7969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZhangX-21
wants to merge
3
commits into
PaddlePaddle:develop
Choose a base branch
from
ZhangX-21:piecewise_cudagraph
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−824
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
320 changes: 0 additions & 320 deletions
320
fastdeploy/model_executor/graph_optimization/cuda_graph_op.py
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Bug 这里在 PD prefill piecewise 模式下无条件把
use_cudagraph置为True,但后面的 CPU cache 兼容性逻辑只检查cudagraph_only_prefill。当
cache_config.num_cpu_blocks非零时,下面的注释已经说明 layer-by-layer swap/H2D 与 CUDA Graph prefill capture 不兼容;但本分支默认cudagraph_only_prefill=False,所以会绕过 2246-2259 的禁用逻辑。随后gpu_worker.graph_optimize_and_warm_up_model()在use_piecewise and not is_pd_decode下仍会调用capture_model_prefill_and_mixed(),启用本应被禁用的 prefill CUDAGraph。建议修复方式:把 piecewise prefill 也纳入同一兼容性判断;例如在
num_cpu_blocks非零且splitwise_role == "prefill" and graph_opt_level >= 1 and not full_cuda_graph时不要打开use_cudagraph,或在后面的 CPU cache 兼容性块里同时将use_cudagraph复位为False并跳过 prefill capture。