[ERNIEBot Researcher] update llama_index #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w5688414
reviewed
Jan 24, 2024
| # TODO: Adapt to llamaindex | ||
| pass | ||
| retriever = self.db.as_retriever(similarity_top_k=top_k) | ||
| nodes = retriever.retrieve(query) |
There was a problem hiding this comment.
给erniebot-agent/src/erniebot_agent/tools/llama_index_retrieval_tool.py和lanchain retrieval tool加上单测，参考我的PR。
| return index | ||
| if not abstract and not origin_data: | ||
| documents = preprocess(path, url_path=url_path, use_langchain=False) | ||
| text_splitter = SentenceSplitter(chunk_size=1024, chunk_overlap=20) |
There was a problem hiding this comment.
SentenceSplitter和langchain 的spacy splitter，哪个更好呢？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.