Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve ch3 with setdefault, mongo simplification and consistent typing #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: improve ch3 with setdefault, mongo simplification and consistent typing #29

wants to merge 3 commits into from

Conversation

weiyu-huang
Copy link

This PR improves code quality in Chapter 3:

  1. Enhance metadata handling:

    • Use dict.setdefault() in add_to_metadata for cleaner default value handling
    • Simplify code by removing redundant dictionary checks

  2. Simplify MongoDB handling:

    • Remove redundant conversion logic in to_mongo method

  3. Modernize type hints:

    • Update to str | None syntax for consistency with surrounding code

@weiyu-huang
Refactor metadata handling using setdefault
a71a201
@weiyu-huang
refactor: remove redundant UUID conversion in to_mongo
524d4a9 
Move UUID string conversion to model_dump to avoid duplicate logic. UUID conversion now happens once during initial dump instead of repeating in to_mongo.
@weiyu-huang
refactor: update type hints to use union syntax
a8e6fc5 
Change Optional[str] to str | None for improved readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@weiyu-huang