Do not destroy the transaction before it has replied #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regardless of the outcome of PackageKit/PackageKit#644, we should address this here to not depend on a PackageKit daemon version bump |
aleasto
force-pushed
the
destroy-after-return
branch
3 times, most recently
from
c2f9d18
to
8566148
Compare
|
I'm not sure what you mean about "return" in here. |
Dbus method call return, or reply. |
Destroy might be signaled before the dbus call has replied. In destroy() we emit a `finished` event with code ExitUnknown, but if the transaction returns an error we should have sent ExitFailed. Furthermore, if we destroy the transaction object before QDBusPendingCallWatcher fires, we might lose that event.
aleasto
force-pushed
the
destroy-after-return
branch
from
8566148
to
3c94288
Compare
aleasto
changed the title
|
@aleixpol bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destroy might be signaled before the dbus call has replied.
In destroy() we emit a
finishedevent with code ExitUnknown, butif the transaction returns an error we should have sent ExitFailed.
Furthermore, if we destroy the transaction object before
QDBusPendingCallWatcher fires, we might lose that event.