cn0: separated C/N0 computation and filtering #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paakkit
force-pushed
the
CNO_master
branch
2 times, most recently
from
4025389 to
3e98024
Compare
valeri-atamaniouk
force-pushed
the
i204-l1ca-cn0-separation
branch
from
963f28f to
2aa7b95
Compare
| void bw2_filter_init(bw2_filter_t *f, float initial, | ||
| float cutoff_freq, float loop_freq); | ||
| float bw2_filter_update(bw2_filter_t *f, float value); | ||
|
|
Owner
There was a problem hiding this comment.
Filter updates take different variable names, "sample vs. value". Could it be the same name for both?
valeri-atamaniouk
force-pushed
the
i204-l1ca-cn0-separation
branch
from
2aa7b95 to
b44ae86
Compare
rge-exafore
force-pushed
the
CNO_master
branch
2 times, most recently
from
125e172 to
143e405
Compare
Conflicts: tests/CMakeLists.txt tests/check_main.c tests/check_suites.h
Separated C/NO computation and filtering algorithms. Updated unit tests and Python bindings. Added SNV CN0 and first order LPF.
Updated lock detector algorithm to avoid float to double conversions.
valeri-atamaniouk
force-pushed
the
i204-l1ca-cn0-separation
branch
from
b44ae86 to
3d7ec3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated C/NO computation and filtering algorithms. Updated unit
tests and Python bindings. Added SNV CN0 and first order LPF.
@Paakkit Please review
@adel-mamin Please review