Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the C++ standard to C++17 #14

Closed
wants to merge 1 commit into from
Closed

Conversation

itsaryan72
Copy link

Added the desired lines in file CMakeLists.txt

Lines Added
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

@bresch bresch closed this Sep 25, 2024
@itsaryan72
Copy link
Author

@bresch can you please elaborate what wrong has been done from my side

@bresch
Copy link
Member

bresch commented Sep 26, 2024

Hi @itsaryan72 ,
I just don't see the point. PX4-Eigen isn't really used anywhere, it's your first public PR and your comment in the PR seems auto-generated. In addition to that we often see people trying to do a PR with a random typo fix just to be in the contributor list and get a badge (e.g.: #11).

If you think those changes are needed, please describe which issue you're trying to solve and why this is really needed. With which project are you using PX4/eigen?
Thanks.

@itsaryan72
Copy link
Author

Thanks for your time @bresch. I am trying to solve issue #13 , as the solution was stated to resolve this issue, set the C++ standard to C++17 in the project's CMakeLists.txt file by adding the following lines:

set(CMAKE_CXX_STANDARD 17) set(CMAKE_CXX_STANDARD_REQUIRED ON) set(CMAKE_CXX_EXTENSIONS OFF)

I just tried to solve it as stated doing the following changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants