Use RF delay instead of RF dead time #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
schuenke
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Independent of the return_gz setting, rf.delay is always at least as big as rf.dead_time (which is equal to system.rf_dead_time). Only when return_gz = true, rf.delay might be increased to grad.rise_time + grad.delay. Thus, just using rf.delay instead of system.rf_dead_time should be enough. No max(a,b) is needed IMO.
ckolbPTB
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helge found out that using
system.rf_dead_timemight not be what is actually used in the RF object:https://github.com/PTB-MR/qmri-low-field/pull/38#issuecomment-2701251207