Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One possible Future(TM) #659

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from
Draft

One possible Future(TM) #659

wants to merge 43 commits into from

Conversation

fzimmermann89
Copy link
Member

@fzimmermann89 fzimmermann89 commented Feb 28, 2025

Tracking unmerged PRs.

this is a good base for new PRs.

ghstack-source-id: 879cd3a874a615e8e3dc723afc6edbe050011d47
ghstack-comment-id: 2644240473
Pull Request resolved: #641
ghstack-source-id: 2c48a3a65d46fc65284bb4c82bc82b1716608091
ghstack-comment-id: 2644240531
Pull Request resolved: #642
ghstack-source-id: 9642407ce53079f78ef9388eba3ecba21f82ef73
ghstack-comment-id: 2644250398
Pull Request resolved: #643
@fzimmermann89 fzimmermann89 changed the base branch from wip_reshape2 to main February 28, 2025 12:47
Copy link
Contributor

github-actions bot commented Feb 28, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mrpro
   _version.py6267%7–8
src/mrpro/algorithms/csm
   inati.py24196%44
   walsh.py16194%53
src/mrpro/algorithms/dcf
   dcf_voronoi.py55493%15, 55–56, 89
src/mrpro/algorithms/optimizers
   adam.py20195%101
   pdhg.py79396%177–178, 184
src/mrpro/algorithms/reconstruction
   DirectReconstruction.py281643%59–79, 93
   IterativeSENSEReconstruction.py13192%79
   Reconstruction.py502256%42, 54–56, 80–87, 108–117
   RegularizedIterativeSENSEReconstruction.py411759%97–101, 115–140
src/mrpro/data
   AcqInfo.py143497%113–114, 116, 225
   CheckDataMixin.py3444088%90, 96, 98, 115, 123, 125, 127, 160–161, 184, 193, 210, 238, 254, 302, 307, 313–318, 348, 355, 446, 448, 480, 482, 484, 488, 504, 545, 550, 627, 649–653, 685, 726–729, 754
   CsmData.py28389%13, 82–84
   DcfData.py44882%16, 64, 76–81
   EncodingLimits.py73396%33, 123, 126
   IData.py59886%118, 132, 159–167
   IHeader.py1331291%69–72, 241, 245, 249, 253, 287–291
   KData.py1982886%113–114, 129, 136, 148–161, 170, 178, 187, 221, 243–245, 281–282, 337–348, 477, 479, 549
   KHeader.py1412185%23, 108–114, 141, 189, 196–197, 200, 207, 224–231, 239–250
   KNoise.py311552%39–52, 56–61
   KTrajectory.py106892%162, 164, 183, 267–271
   MoveDataMixin.py1401887%28, 126, 142, 156–158, 220, 336–338, 351, 430, 450–451, 453, 468–469, 471
   QData.py39782%42, 65–73
   ReduceRepeatMixin.py33294%51–52
   Rotation.py7193595%101, 199, 336, 434, 478, 496, 583, 585, 594, 628, 630, 693, 770, 775, 778, 793, 810, 815, 891, 1079, 1084, 1087, 1111, 1115, 1243, 1245, 1253–1254, 1318, 1400, 1703, 1855, 1890, 1894, 2084
   SpatialDimension.py2322191%34, 104, 141, 148, 154, 274–276, 289–291, 325, 343, 356, 369, 382, 395, 404–405, 420, 429
   acq_filters.py12192%47
src/mrpro/data/traj_calculators
   KTrajectoryCalculator.py27196%84
   KTrajectoryIsmrmrd.py16194%43
src/mrpro/operators
   CartesianSamplingOp.py89397%124, 163, 286
   ConstraintsOp.py60297%46, 48
   DictionaryMatchOp.py52688%98–102, 122
   EndomorphOperator.py32294%52, 58
   FiniteDifferenceOp.py27293%40, 105
   FourierOp.py73297%234, 239
   Functional.py77988%20–22, 117, 119, 226–228, 242
   GridSamplingOp.py136993%72–73, 82–83, 90–91, 94, 96, 98
   LinearOperator.py2001095%48, 107, 217, 244, 251, 292, 301, 309, 326, 361
   LinearOperatorMatrix.py1621988%82, 119, 152, 161, 166, 175–178, 191–194, 202–203, 208–209, 221, 310, 337, 364
   MultiIdentityOp.py13285%43, 48
   NonUniformFastFourierOp.py1771094%69, 96, 206, 208, 241, 243, 302, 356, 406, 411
   Operator.py79297%32, 88
   ProximableFunctionalSeparableSum.py39392%50, 103, 110
   SliceProjectionOp.py174895%45, 62, 64, 70, 206, 227, 260, 300
   WaveletOp.py119596%151, 169, 204, 209, 232
   ZeroPadOp.py16194%30
src/mrpro/operators/models
   EPG.py2024379%46, 55, 63, 88–99, 147–151, 171–173, 193–197, 226, 240, 245, 261–263, 279–280, 285, 305, 310, 330, 335, 381–382, 545, 645
   cMRF.py33197%67
src/mrpro/phantoms
   brainweb.py2752691%325–335, 371, 427–430, 452–453, 458–459, 474, 520, 586–587, 606–609, 620, 622, 657–658, 671
src/mrpro/utils
   filters.py62297%44, 49
   indexing.py170199%325
   reshape.py97298%112, 303
   slice_profiles.py47687%21, 37, 116–119, 152
   sliding_window.py34197%34
   split_idx.py10280%43, 47
   summarize_tensorvalues.py12925%22–31
   typing.py695520%9–235
   unit_conversion.py601477%32, 40, 42, 49, 51, 58, 60, 69, 80, 82, 101, 103, 124, 126
   zero_pad_or_crop.py31681%26, 30, 55, 58, 61, 64
TOTAL650156791% 

Tests Skipped Failures Errors Time
2531 0 💤 0 ❌ 0 🔥 1m 57s ⏱️

@fzimmermann89 fzimmermann89 force-pushed the next branch 2 times, most recently from 89a4232 to 598d78a Compare February 28, 2025 14:20
@fzimmermann89 fzimmermann89 marked this pull request as draft February 28, 2025 14:26
@fzimmermann89 fzimmermann89 changed the title One possible Future One possible Future(TM) Feb 28, 2025
Copy link
Contributor

github-actions bot commented Feb 28, 2025

📚 Documentation

📁 Download as zip
🔍 View online

@fzimmermann89 fzimmermann89 force-pushed the next branch 2 times, most recently from f6218c0 to ccdfc00 Compare March 2, 2025 01:58
ghstack-source-id: 3d20834bc290babd389ad41f51f3126bf2353756
ghstack-comment-id: 2688426513
Pull Request resolved: #655
ghstack-source-id: c45e3d099a6673cb9f10c6cd9e3f00dc63c8f126
ghstack-comment-id: 2688426689
Pull Request resolved: #656
ghstack-source-id: 2136a95ff5864d4dfb09f1d44b3245e28021277a
ghstack-comment-id: 2501006700
Pull Request resolved: #560
ghstack-source-id: 7b5c82241284cb5de6d93685c77673cd690d30fb
ghstack-comment-id: 2694165931
Pull Request resolved: #679
ghstack-source-id: 113bd97f48678694fd1182136753d3e0818b36ab
ghstack-comment-id: 2559847826
Pull Request resolved: #591
ghstack-source-id: 645e4edea45bf3740739dd23e1e3cb0e5f0b3deb
ghstack-comment-id: 2691622453
Pull Request resolved: #660
Add complex m0, and sensible random ranges for values.
Add isfinite checks.
Fix some comments and no-op tests.
Allow Sequence of float inputs in inits.
Add type hints

ghstack-source-id: 364ffe4cd58e5f5af538c52092ec5051ae995362
ghstack-comment-id: 2693835436
Pull Request resolved: #671
ghstack-source-id: 30dbfa796cda6bebe3f73dcea552f5c96984447e
ghstack-comment-id: 2693835606
Pull Request resolved: #672
ghstack-source-id: f9918677e12c5234cf03873f8e721ce4cbbb67a6
ghstack-comment-id: 2693835776
Pull Request resolved: #673
ghstack-source-id: de1078431a46890ca7d82ca0a9feb5a644596c0a
ghstack-comment-id: 2693835968
Pull Request resolved: #674
ghstack-source-id: f5901319928b6fd44ef8275c3f6ba37676545b23
ghstack-comment-id: 2564579214
Pull Request resolved: #594
@fzimmermann89 fzimmermann89 force-pushed the next branch 2 times, most recently from 8fb4284 to 57b6f6c Compare March 4, 2025 14:25
@fzimmermann89 fzimmermann89 reopened this Mar 10, 2025
commit 0d0f192e11a0b1db7404651f6ac28b5953746f5f
Author: Felix Zimmermann <[email protected]>
Date:   Thu Mar 13 15:35:19 2025 +0100

    broadcast in relax
commit 7a6ad39
Author: Felix Zimmermann <[email protected]>
Date:   Fri Mar 14 01:40:07 2025 +0100

    py310

commit cf58e03
Author: Felix Zimmermann <[email protected]>
Date:   Fri Mar 14 01:34:30 2025 +0100

    py310

commit 9caa056
Author: Felix Zimmermann <[email protected]>
Date:   Fri Mar 14 01:31:23 2025 +0100

    default

commit 85b0fd9
Author: Felix Zimmermann <[email protected]>
Date:   Fri Mar 14 01:28:53 2025 +0100

    fix

commit 6785ccf
Author: Felix Zimmermann <[email protected]>
Date:   Fri Mar 14 01:10:50 2025 +0100

    add avg op

commit 704fecd
Author: Stefan Martin <[email protected]>
Date:   Tue Mar 11 11:31:43 2025 +0100

    Fix examples in readme (#713)

commit 77290ef
Author: bernharb <[email protected]>
Date:   Mon Mar 10 12:13:56 2025 +0100

    Fix naming of RearrangeOp tests (#711)

commit 2e6e0d0
Author: bernharb <[email protected]>
Date:   Mon Mar 10 11:19:56 2025 +0100

    Add tolerance to rotation mean test (#710)

commit d87ab35
Author: Leonid Lunin <[email protected]>
Date:   Fri Mar 7 15:03:53 2025 +0100

    Add python 3.13 support (#704)

commit d286092
Author: Felix F Zimmermann <[email protected]>
Date:   Fri Mar 7 14:27:29 2025 +0100

    Fix batched complex grid sampling (#695)

commit d52987d
Author: Christoph Kolbitsch <[email protected]>
Date:   Fri Mar 7 14:22:08 2025 +0100

    Update readme on fork and pull request (#653)

commit 133a11e
Author: Stefan Martin <[email protected]>
Date:   Fri Mar 7 11:06:05 2025 +0100

    Change iteration argument name in optimizers (#687)

    Co-authored-by: Felix F Zimmermann <[email protected]>

commit 2988477
Author: Felix F Zimmermann <[email protected]>
Date:   Thu Mar 6 20:26:00 2025 +0100

    Add Jacobian of Operator (#452)

commit 6a9eb16
Author: rkcatarina <[email protected]>
Date:   Thu Mar 6 20:09:11 2025 +0100

    Update zenodo citation (#698)

commit 3aa5aeb
Author: Felix F Zimmermann <[email protected]>
Date:   Thu Mar 6 20:04:43 2025 +0100

    Reduce RAM usage in tests (#703)

commit 870967c
Author: Mara Guastini <[email protected]>
Date:   Thu Mar 6 16:32:33 2025 +0100

    Add stopping criterion to optimizer callback (#699)

commit 10aa16c
Author: Felix F Zimmermann <[email protected]>
Date:   Thu Mar 6 16:17:03 2025 +0100

    Indexing helper (#672)

commit 15060bf
Author: Christoph Kolbitsch <[email protected]>
Date:   Thu Mar 6 10:56:11 2025 +0100

    Add gradient and autodiff checks for linear operators (#536)

    Co-authored-by: Felix F Zimmermann <[email protected]>

commit 6d4b221
Author: Felix F Zimmermann <[email protected]>
Date:   Thu Mar 6 10:50:30 2025 +0100

    Release v0.250306 (#697)

commit ad7b6e0
Author: rkcatarina <[email protected]>
Date:   Thu Mar 6 01:12:25 2025 +0100

    Rename ti to saturation_time in saturation recovery model (#689)

commit 3839a07
Author: Felix F Zimmermann <[email protected]>
Date:   Wed Mar 5 20:23:51 2025 +0100

    Refactor signal model tests (#671)

commit d4bd171
Author: Stefan Martin <[email protected]>
Date:   Wed Mar 5 20:18:48 2025 +0100

    Add __repr__ to Fourier operators (#676)

    Co-authored-by: Felix F Zimmermann <[email protected]>

commit 08a60e9
Author: Felix F Zimmermann <[email protected]>
Date:   Wed Mar 5 20:13:45 2025 +0100

    Make Trajectory and Idx 5D (#660)

    Makes all of our dataclasses at least 5D.
    So acq_idx get a (singleton) k0 dimension, trajectory a singleton coil dimension etc.

commit a7a5e2f
Author: Felix F Zimmermann <[email protected]>
Date:   Wed Mar 5 17:34:49 2025 +0100

    Use gram in operator_norm (#682)

commit c301e1b
Author: Felix F Zimmermann <[email protected]>
Date:   Wed Mar 5 17:29:40 2025 +0100

    Add more information to IHeader (#591)

commit 65b965c
Author: Felix F Zimmermann <[email protected]>
Date:   Wed Mar 5 17:23:11 2025 +0100

    Rename remove_repeat to reduce_repeat and add tests (#679)

commit 8e79e74
Author: Felix F Zimmermann <[email protected]>
Date:   Wed Mar 5 17:17:24 2025 +0100

    Refactor AcqInfo and Trajectory Calculation (#560)

commit 14e4058
Author: Felix F Zimmermann <[email protected]>
Date:   Wed Mar 5 15:32:04 2025 +0100

    Fix torchvision in docker images (#693)

commit 2bd6e29
Author: Felix F Zimmermann <[email protected]>
Date:   Wed Mar 5 15:19:38 2025 +0100

    Add unsqeeze_at (#656)

commit 274e203
Author: Felix F Zimmermann <[email protected]>
Date:   Wed Mar 5 15:03:29 2025 +0100

    Make Rotation einops compatible (#655)

commit b9840b8
Author: Felix F Zimmermann <[email protected]>
Date:   Wed Mar 5 14:32:33 2025 +0100

    Add Brainweb phantom (#630)

commit 7fe0014
Author: Mara Guastini <[email protected]>
Date:   Wed Mar 5 13:52:06 2025 +0100

    Add pgd (fista) algorithm (#293)

    Co-authored-by: Felix F Zimmermann <[email protected]>
    Co-authored-by: Christoph Kolbitsch <[email protected]>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: koflera <[email protected]>

commit c80ad02
Author: Andreas Kofler <[email protected]>
Date:   Wed Mar 5 13:20:57 2025 +0100

    Bump pydicom dependency (#685)

commit a14fde8
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Wed Mar 5 10:56:54 2025 +0100

    [pre-commit] pre-commit autoupdate (#681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants