Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 휴대폰 문자 인증 API #98

Merged
merged 5 commits into from
Aug 10, 2023
Merged

[feat] 휴대폰 문자 인증 API #98

merged 5 commits into from
Aug 10, 2023

Conversation

chaerlo127
Copy link
Collaborator

@chaerlo127 chaerlo127 commented Aug 9, 2023 •
edited
Loading

🌱 이슈 번호

close #59


💬 기타 사항

  • 아직 PSR 네이버 클라우드 계정 번호가 연동이 안되어 있어서, 제 계정으로 생성해뒀슴니당
  • 계정 내 번호가 연동이 되면 YAML 파일 내 key 변경할게용
  • 만료시간 2분으로 되어 있슴니다

@chaerlo127 chaerlo127 added 🔮 feat 기능을 생성해요 ! 🐣 chae-eun 채은이가 만든 기능이에요 ! 👩🏻‍💻 users 사용자 도메인 기능이에요 ! labels Aug 9, 2023
@chaerlo127 chaerlo127 self-assigned this Aug 9, 2023
@chaerlo127 chaerlo127 added the 🌿 refactor 코드 구조를 변경해요 ! label Aug 9, 2023
psyeon1120
psyeon1120 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@psyeon1120 psyeon1120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

신기방긔

sojungpp
sojungpp approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@sojungpp sojungpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무싯다,, 진짜 신기방기진기명기

chaerlo127
chaerlo127 commented Aug 10, 2023
View reviewed changes
src/main/kotlin/com/psr/psr/global/jwt/utils/JwtUtils.kt
Comment on lines +148 to +151
* 휴대폰 smsKey 만료시간
*/
fun createSmsKey(phone: String, smsKey: String){
// 재발급을 받은 경우 기존 인증코드 삭제
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 jwt 관련 로직은 아니지만, redis 에 접근하기 위해 이 곳에 생성해두었습니다!
redis 관련 접근 코드만 생성하는 service class를 만드는 게 좋을것 같아서, 시간 날 때 리펙 해둘게요!

@chaerlo127 chaerlo127 merged commit 17bb6ae into develop Aug 10, 2023
1 check passed
@chaerlo127 chaerlo127 deleted the feat/#59-checkValidPhone branch August 17, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psyeon1120 psyeon1120 psyeon1120 approved these changes

@sojungpp sojungpp sojungpp approved these changes

Assignees

@chaerlo127 chaerlo127

Labels
🐣 chae-eun 채은이가 만든 기능이에요 ! 🔮 feat 기능을 생성해요 ! 🌿 refactor 코드 구조를 변경해요 ! 👩🏻‍💻 users 사용자 도메인 기능이에요 !
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 전화번호 인증번호 발송
3 participants
@chaerlo127 @psyeon1120 @sojungpp