[feat] 관심 목록 변경 API #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaerlo127
added
🔮 feat
chaerlo127
commented
Aug 6, 2023
| @@ -28,7 +28,7 @@ class ProductService( | |||
| var interestCategoryList: MutableList<Category> = ArrayList() | |||
| if(category.isEmpty()) { | |||
| // 유저의 관심목록 | |||
| val userInterestList = userInterestRepository.findByUser(user); | |||
| val userInterestList = userInterestRepository.findByUserAndStatus(user, ACTIVE_STATUS); | |||
There was a problem hiding this comment.
요거 status 확인이 필요한 것 같아서 userInterestRepository method 변경하는 김에 한번에 변경해뒀슴니당
@sojungpp
Comment on lines
+219
to
+236
| // 사용자 관심 목록에 최근 추가한 리스트(REQUEST) 관심 목록이 없다면? => 저장 | ||
| reqLists.stream() | ||
| .forEach { interest -> | ||
| if(!categoryLists.contains(interest)) { | ||
| // 과거에 삭제했던 경우 / 새롭게 생성하는 경우 | ||
| val interestE = userInterestRepository.findByUserAndCategory(user, interest)?: userAssembler.toInterestEntity(user, interest) | ||
| interestE.status = ACTIVE_STATUS | ||
| userInterestRepository.save(interestE) | ||
| } | ||
| } | ||
|
|
||
| // 최근 추가한 리스트(REQUEST)에 사용자 관심 목록이 없다면? => 삭제 | ||
| userWatchLists.stream() | ||
| .forEach { interest -> | ||
| // todo: cascade 적용 후 모두 삭제 되었는지 확인 필요 | ||
| if(!reqLists.contains(interest.category)) userInterestRepository.delete(interest) | ||
| } | ||
| } |
There was a problem hiding this comment.
| @@ -80,6 +81,7 @@ class UserService( | |||
| } | |||
|
|
|||
| // 로그인 | |||
| @Transactional | |||
There was a problem hiding this comment.
추가하지 못했던 Transactional 추가,, 🌞
psyeon1120
approved these changes
Aug 6, 2023
Comment on lines
+219
to
+236
| // 사용자 관심 목록에 최근 추가한 리스트(REQUEST) 관심 목록이 없다면? => 저장 | ||
| reqLists.stream() | ||
| .forEach { interest -> | ||
| if(!categoryLists.contains(interest)) { | ||
| // 과거에 삭제했던 경우 / 새롭게 생성하는 경우 | ||
| val interestE = userInterestRepository.findByUserAndCategory(user, interest)?: userAssembler.toInterestEntity(user, interest) | ||
| interestE.status = ACTIVE_STATUS | ||
| userInterestRepository.save(interestE) | ||
| } | ||
| } | ||
|
|
||
| // 최근 추가한 리스트(REQUEST)에 사용자 관심 목록이 없다면? => 삭제 | ||
| userWatchLists.stream() | ||
| .forEach { interest -> | ||
| // todo: cascade 적용 후 모두 삭제 되었는지 확인 필요 | ||
| if(!reqLists.contains(interest.category)) userInterestRepository.delete(interest) | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 이슈 번호
close #60
💬 기타 사항