Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 요청 수정 API 생성 #71

Merged
merged 2 commits into from
Aug 6, 2023
Merged

[feat] 요청 수정 API 생성 #71

merged 2 commits into from
Aug 6, 2023

Conversation

psyeon1120
Copy link
Member

🌱 이슈 번호

close #69


💬 기타 사항

  • orderReq 같이 쓰고 싶어서 조금 바꿨는데 그래도 괜찮겠죵?

@psyeon1120 psyeon1120 added 🔮 feat 기능을 생성해요 ! ☀️ seoyeon 서연이가 만든 기능이에요 ! 👩‍💻 orders 요청 도메인 기능이에요 ! labels Aug 6, 2023
@psyeon1120 psyeon1120 self-assigned this Aug 6, 2023
@@ -39,4 +40,11 @@ data class Order(
@NotNull
var isReviewed: Boolean = false

) : BaseEntity()
) : BaseEntity() {
fun editOrder(orderReq: OrderReq) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요렇게 해도 괜찮은가요?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전 좋은 것 같아유 -!!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저두 조하용

@@ -21,7 +21,7 @@ class OrderService(
) {
// 요청하기
fun makeOrder(user: User, orderReq: OrderReq) {
val product: Product = productRepository.findByIdAndStatus(orderReq.productId, ACTIVE_STATUS)
val product: Product = orderReq.productId?.let { productRepository.findByIdAndStatus(it, ACTIVE_STATUS) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 신기하다 끝이없는 코틀린세상

Copy link
Member

@sojungpp sojungpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

또 하나 알아가는 코드 ㅋㅑ

fun editOrder(
@AuthenticationPrincipal userAccount: UserAccount,
@PathVariable orderId: Long,
@RequestBody(required = false) @Valid orderReq: OrderReq?,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유레카

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 미춋다 대박

Copy link
Collaborator

@chaerlo127 chaerlo127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최굡!!

fun editOrder(
@AuthenticationPrincipal userAccount: UserAccount,
@PathVariable orderId: Long,
@RequestBody(required = false) @Valid orderReq: OrderReq?,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 미춋다 대박

@psyeon1120 psyeon1120 merged commit 61c831a into develop Aug 6, 2023
1 check passed
@psyeon1120 psyeon1120 deleted the feat/#69-edit-order branch August 6, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 feat 기능을 생성해요 ! 👩‍💻 orders 요청 도메인 기능이에요 ! ☀️ seoyeon 서연이가 만든 기능이에요 !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 요청 수정 API
3 participants