Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] DB 생성 #10

Merged
merged 10 commits into from
Jul 23, 2023
Merged

[feat] DB 생성 #10

merged 10 commits into from
Jul 23, 2023

Conversation

sojungpp
Copy link
Member

🌱 이슈 번호

close #1


💬 기타 사항

  • ENUM 변수명 확인해주세요 !
  • DB 같이 정한대로 우선 생성했는데, 같이 의논하고 싶은 부분이 있어서 리뷰로 달아두겠습니다
  • 늦어서 죄송합니다 사랑합니다

@sojungpp sojungpp added 🔮 feat 기능을 생성해요 ! 😽 sojung 소정이가 만든 기능이에요 ! labels Jul 21, 2023
@sojungpp sojungpp self-assigned this Jul 21, 2023
chaerlo127
chaerlo127 approved these changes Jul 22, 2023
View reviewed changes
Copy link
Collaborator

@chaerlo127 chaerlo127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바빴을텐데 수고 너무 많았숨니다🤍🤍
title, content도 앞에 엔터티 이름을 적지 않았으니 imgKey도 엔터티 이름 붙이지 않고 통일하는건 어떨까욤

psyeon1120
psyeon1120 requested changes Jul 22, 2023
View reviewed changes
Copy link
Member

@psyeon1120 psyeon1120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 그냥 imgKey로 통일하는게 좋을 것 같아요오
왜 저 새벽에 작업한겨ㅠㅠㅠㅠ 오늘 화이팅이예요오

src/main/kotlin/com/psr/psr/chat/entity/ChatRoom.kt Outdated
var id: Long,

@ManyToOne
@JoinColumn(nullable = false, name = "sender_user_idx")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idx로 쓴 이유가 있나용??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fault .. 수정햇웁니다

src/main/kotlin/com/psr/psr/cs/entity/Faq.kt
@NotNull
var content: String,

@NotNull
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enum 쓴 부분은 @Enumerated(EnumType.STRING)가 필요할 것 같습니다!
지금 DB에는 tinyint로 되어있어용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니당당 수정완!!

psyeon1120
psyeon1120 approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@psyeon1120 psyeon1120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@sojungpp sojungpp merged commit 6dd263d into develop Jul 23, 2023
1 check passed
@sojungpp sojungpp deleted the feat/#1-project-setting branch August 9, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psyeon1120 psyeon1120 psyeon1120 approved these changes

@chaerlo127 chaerlo127 chaerlo127 approved these changes

Assignees

@sojungpp sojungpp

Labels
🔮 feat 기능을 생성해요 ! 😽 sojung 소정이가 만든 기능이에요 !
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 프로젝트 초기 설정
3 participants
@sojungpp @psyeon1120 @chaerlo127