Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[33] - Modified pom.xml to append properties files during build and added cz… #106

Conversation

anandamideShakyan
Copy link
Contributor

@anandamideShakyan anandamideShakyan commented Jul 6, 2024

Modified pom.xml to append properties files during build and added cz-duration to application.properties

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix
  • New feature
  • Enhancement
  • Refactoring
  • Documentation
  • Other ( please specify )

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

pom.xml Outdated
@@ -44,6 +44,10 @@
<server-id>wildfly-${environment}</server-id>
<server-hostname>{hostname-${environment}}</server-hostname>
<server-port>{port-${environment}}</server-port>
<wildfly.hostname>localhost</wildfly.hostname>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

avniRegistrationLimit=7

#--------------------------NHM Agent Real Time Data----------------------------
nhm.agent.real.time.data.url= http://175.101.1.83/apps/utility/alive_api.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be hardcoding this IP?

@devikasuresh20, @ravishanigarapu what's this about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the hardcoded ip.

Copy link

sonarcloud bot commented Jul 29, 2024

@drtechie drtechie merged commit 953cd78 into PSMRI:feature/version/upgrade Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants